Checkstyle Results

The following document contains the results of Checkstyle . rss feed

Summary

Files Infos info Warnings warning Errors error
39 0 331 0

Rules

Rules Violations Severity
JavadocMethod 93 error Error
JavadocType 20 error Error
JavadocVariable 11 error Error
JavadocStyle 0 error Error
ConstantName 0 error Error
LocalFinalVariableName 0 error Error
LocalVariableName 0 error Error
MemberName 0 error Error
MethodName 0 error Error
PackageName 0 error Error
ParameterName 0 error Error
StaticVariableName 0 error Error
TypeName 0 error Error
AvoidStarImport 0 error Error
IllegalImport 0 error Error
RedundantImport 0 error Error
UnusedImports 2 error Error
FileLength 0 error Error
MethodLength 0 error Error
ParameterNumber 0 error Error
ModifierOrder 0 error Error
RedundantModifier 20 error Error
AvoidNestedBlocks 0 error Error
EmptyBlock 0 error Error
LeftCurly 0 error Error
NeedBraces 2 error Error
RightCurly 0 error Error
AvoidInlineConditionals 0 error Error
DoubleCheckedLocking 0 error Error
EmptyStatement 0 error Error
EqualsHashCode 0 error Error
IllegalInstantiation 0 error Error
InnerAssignment 0 error Error
MagicNumber 0 error Error
MissingSwitchDefault 0 error Error
RedundantThrows 0 error Error
SimplifyBooleanExpression 0 error Error
SimplifyBooleanReturn 0 error Error
DesignForExtension 41 error Error
FinalClass 1 error Error
HideUtilityClassConstructor 0 error Error
InterfaceIsType 0 error Error
VisibilityModifier 0 error Error
ArrayTypeStyle 0 error Error
FinalParameters 99 error Error
UpperEll 0 error Error
LineLength
  • max : "120"
27 error Error
CyclomaticComplexity 3 error Error
ClassDataAbstractionCoupling 1 error Error
ClassFanOutComplexity 0 error Error
BooleanExpressionComplexity 0 error Error
JavaNCSS 1 error Error
NPathComplexity 1 error Error
PackageHtml 9 error Error
NewlineAtEndOfFile 0 error Error
Translation 0 error Error

Files

Files I info W warning E error
net/sf/hattori/PopulationManager.java 0 35 0
net/sf/hattori/exceptions/package.html 0 1 0
net/sf/hattori/annotations/CollectionFieldPopulation.java 0 6 0
net/sf/hattori/repository/package.html 0 1 0
net/sf/hattori/populators/package.html 0 1 0
net/sf/hattori/populators/domain/ByNameDomainObjectFieldPopulator.java 0 17 0
net/sf/hattori/repository/PersistentObjectDTO.java 0 9 0
net/sf/hattori/log/Logger.java 0 13 0
net/sf/hattori/populators/dto/DTOFieldPopulator.java 0 11 0
net/sf/hattori/populators/StaticPopulator.java 0 3 0
net/sf/hattori/annotations/util/package.html 0 1 0
net/sf/hattori/repository/AbstractPersistentObject.java 0 23 0
net/sf/hattori/package.html 0 1 0
net/sf/hattori/populators/domain/AbstractDomainObjectFieldPopulator.java 0 9 0
net/sf/hattori/annotations/ObjectPopulation.java 0 7 0
net/sf/hattori/populators/dto/package.html 0 1 0
net/sf/hattori/populators/ObjectPopulator.java 0 6 0
net/sf/hattori/populators/AbstractFieldAccessor.java 0 6 0
net/sf/hattori/populators/DynamicPopulator.java 0 17 0
net/sf/hattori/repository/AbstractPersistentObjectDTO.java 0 26 0
net/sf/hattori/repository/EntityLocator.java 0 5 0
net/sf/hattori/populators/domain/DomainObjectCollectionFieldPopulator.java 0 24 0
net/sf/hattori/populators/domain/DomainObjectDirectFieldPopulator.java 0 13 0
net/sf/hattori/annotations/util/AbstractPersistentObjectStaticPopulator.java 0 6 0
net/sf/hattori/annotations/FieldPopulation.java 0 1 0
net/sf/hattori/repository/PersistentObject.java 0 10 0
net/sf/hattori/log/package.html 0 1 0
net/sf/hattori/annotations/package.html 0 1 0
net/sf/hattori/populators/dto/DTOCollectionFieldPopulator.java 0 11 0
net/sf/hattori/populators/dto/ByNameDTOFieldPopulator.java 0 9 0
net/sf/hattori/exceptions/ConcurrentDTOException.java 0 9 0
net/sf/hattori/exceptions/AnnotationConfigurationException.java 0 8 0
net/sf/hattori/exceptions/DTOPopulationException.java 0 8 0
net/sf/hattori/populators/PopulationState.java 0 3 0
net/sf/hattori/populators/dto/DTODirectFieldPopulator.java 0 14 0
net/sf/hattori/annotations/util/UndefinedStaticPopulator.java 0 8 0
net/sf/hattori/populators/domain/package.html 0 1 0
net/sf/hattori/populators/dto/NoOperationDTOFieldPopulator.java 0 5 0

Details

net/sf/hattori/PopulationManager.java

Violation Message Line
warning Missing a Javadoc comment. 28
warning Missing a Javadoc comment. 30
warning Missing a Javadoc comment. 32
warning Unused @throws tag for 'IllegalStateException'. 42
warning Method 'getEntityLocator' is not designed for extension - needs to be abstract, final or empty. 53
warning Missing a Javadoc comment. 53
warning Method 'setEntityLocator' is not designed for extension - needs to be abstract, final or empty. 57
warning Missing a Javadoc comment. 57
warning Parameter entityLocator should be final. 57
warning Missing a Javadoc comment. 61
warning Method 'populateDTOList' is not designed for extension - needs to be abstract, final or empty. 65
warning Missing a Javadoc comment. 65
warning Parameter domainObjects should be final. 65
warning Parameter dtoClass should be final. 66
warning Line is longer than 120 characters. 75
warning Method 'populateDTO' is not designed for extension - needs to be abstract, final or empty. 75
warning Missing a Javadoc comment. 75
warning Parameter domainObject should be final. 75
warning Parameter dtoClass should be final. 75
warning Line is longer than 120 characters. 79
warning Line is longer than 120 characters. 85
warning Missing a Javadoc comment. 92
warning Parameter domainObject should be final. 92
warning Parameter dto should be final. 92
warning Method 'populateDomainObject' is not designed for extension - needs to be abstract, final or empty. 122
warning Parameter dto should be final. 122
warning Parameter entityLocator should be final. 122
warning Expected @param tag for 'entityLocator'. 122
warning Line is longer than 120 characters. 146
warning Missing a Javadoc comment. 158
warning Parameter dto should be final. 158
warning Parameter domainObject should be final. 158
warning Method 'getPopulator' is not designed for extension - needs to be abstract, final or empty. 172
warning Missing a Javadoc comment. 172
warning Parameter dto should be final. 172

net/sf/hattori/exceptions/package.html

Violation Message Line
warning Missing package documentation file. 0

net/sf/hattori/annotations/CollectionFieldPopulation.java

Violation Message Line
warning Missing a Javadoc comment. 10
warning Missing a Javadoc comment. 13
warning Redundant 'public' modifier. 13
warning Missing a Javadoc comment. 15
warning Missing a Javadoc comment. 17
warning Redundant 'public' modifier. 17

net/sf/hattori/repository/package.html

Violation Message Line
warning Missing package documentation file. 0

net/sf/hattori/populators/package.html

Violation Message Line
warning Missing package documentation file. 0

net/sf/hattori/populators/domain/ByNameDomainObjectFieldPopulator.java

Violation Message Line
warning Missing a Javadoc comment. 14
warning Method 'populateField' is not designed for extension - needs to be abstract, final or empty. 19
warning Parameter dtoField should be final. 19
warning Expected @param tag for 'dtoField'. 19
warning Parameter dto should be final. 19
warning Expected @param tag for 'dto'. 19
warning Parameter domainObject should be final. 19
warning Expected @param tag for 'domainObject'. 19
warning Cyclomatic Complexity is 12 (max allowed is 10). 28
warning Missing a Javadoc comment. 28
warning Parameter dtoField should be final. 28
warning Parameter dto should be final. 28
warning Parameter domainObject should be final. 28
warning Line is longer than 120 characters. 38
warning Line is longer than 120 characters. 39
warning Line is longer than 120 characters. 57
warning Line is longer than 120 characters. 69

net/sf/hattori/repository/PersistentObjectDTO.java

Violation Message Line
warning Redundant 'public' modifier. 19
warning Missing a Javadoc comment. 21
warning Redundant 'public' modifier. 21
warning Missing a Javadoc comment. 23
warning Redundant 'public' modifier. 23
warning Missing a Javadoc comment. 25
warning Redundant 'public' modifier. 25
warning Missing a Javadoc comment. 27
warning Redundant 'public' modifier. 27

net/sf/hattori/log/Logger.java

Violation Message Line
warning Class Logger should be declared as final. 5
warning Missing a Javadoc comment. 5
warning Missing a Javadoc comment. 6
warning Missing a Javadoc comment. 8
warning Missing a Javadoc comment. 15
warning Parameter message should be final. 15
warning Missing a Javadoc comment. 19
warning Parameter message should be final. 19
warning Missing a Javadoc comment. 23
warning Parameter t should be final. 23
warning Missing a Javadoc comment. 27
warning Parameter error should be final. 27
warning Parameter t should be final. 27

net/sf/hattori/populators/dto/DTOFieldPopulator.java

Violation Message Line
warning Missing a Javadoc comment. 12
warning Missing a Javadoc comment. 14
warning Method 'setDirectPopulationFieldValue' is not designed for extension - needs to be abstract, final or empty. 26
warning Parameter dto should be final. 26
warning Expected @param tag for 'dto'. 26
warning Parameter dtoField should be final. 26
warning Expected @param tag for 'dtoField'. 26
warning Parameter domainObject should be final. 26
warning Expected @param tag for 'domainObject'. 26
warning Parameter domainField should be final. 27
warning Expected @param tag for 'domainField'. 27

net/sf/hattori/populators/StaticPopulator.java

Violation Message Line
warning Line is longer than 120 characters. 15
warning Type Javadoc comment is missing an @param <DOClass> tag. 15
warning Type Javadoc comment is missing an @param <DTOClass> tag. 15

net/sf/hattori/annotations/util/package.html

Violation Message Line
warning Missing package documentation file. 0

net/sf/hattori/repository/AbstractPersistentObject.java

Violation Message Line
warning Missing a Javadoc comment. 16
warning Missing a Javadoc comment. 19
warning Missing a Javadoc comment. 23
warning Method 'getId' is not designed for extension - needs to be abstract, final or empty. 27
warning Missing a Javadoc comment. 27
warning Method 'setId' is not designed for extension - needs to be abstract, final or empty. 31
warning Missing a Javadoc comment. 31
warning Parameter id should be final. 31
warning Method 'isTransient' is not designed for extension - needs to be abstract, final or empty. 35
warning Missing a Javadoc comment. 35
warning Method 'equals' is not designed for extension - needs to be abstract, final or empty. 39
warning Missing a Javadoc comment. 39
warning Parameter o should be final. 39
warning Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 44
warning Missing a Javadoc comment. 44
warning Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. 48
warning Missing a Javadoc comment. 48
warning Parameter o should be final. 48
warning Method 'toString' is not designed for extension - needs to be abstract, final or empty. 53
warning Missing a Javadoc comment. 53
warning Method 'getVersion' is not designed for extension - needs to be abstract, final or empty. 62
warning Method 'setVersion' is not designed for extension - needs to be abstract, final or empty. 74
warning Parameter version should be final. 74

net/sf/hattori/package.html

Violation Message Line
warning Missing package documentation file. 0

net/sf/hattori/populators/domain/AbstractDomainObjectFieldPopulator.java

Violation Message Line
warning Missing a Javadoc comment. 12
warning Missing a Javadoc comment. 14
warning Method 'setDomainField' is not designed for extension - needs to be abstract, final or empty. 16
warning Missing a Javadoc comment. 16
warning Parameter dto should be final. 16
warning Parameter dtoField should be final. 16
warning Parameter domainObject should be final. 16
warning Parameter domainField should be final. 16
warning Line is longer than 120 characters. 34

net/sf/hattori/annotations/ObjectPopulation.java

Violation Message Line
warning Unused Javadoc tag. 31
warning Redundant 'public' modifier. 33
warning Unused Javadoc tag. 38
warning Redundant 'public' modifier. 40
warning Missing a Javadoc comment. 42
warning Redundant 'public' modifier. 42
warning Redundant 'public' modifier. 49

net/sf/hattori/populators/dto/package.html

Violation Message Line
warning Missing package documentation file. 0

net/sf/hattori/populators/ObjectPopulator.java

Violation Message Line
warning Type Javadoc comment is missing an @param <DOClass> tag. 14
warning Type Javadoc comment is missing an @param <DTOClass> tag. 14
warning Missing a Javadoc comment. 16
warning Redundant 'public' modifier. 16
warning Missing a Javadoc comment. 17
warning Redundant 'public' modifier. 17

net/sf/hattori/populators/AbstractFieldAccessor.java

Violation Message Line
warning Method 'getPropertyName' is not designed for extension - needs to be abstract, final or empty. 18
warning Missing a Javadoc comment. 18
warning Parameter field should be final. 18
warning Method 'fieldIsInitializedValue' is not designed for extension - needs to be abstract, final or empty. 47
warning Parameter mapping should be final. 47
warning Parameter objectToInspect should be final. 47

net/sf/hattori/populators/DynamicPopulator.java

Violation Message Line
warning Missing a Javadoc comment. 27
warning Class Data Abstraction Coupling is 9 (max allowed is 7) classes [ByNameDTOFieldPopulator, DTOCollectionFieldPopulator, DomainObjectDirectFieldPopulator, AnnotationConfigurationException, IdentityMap, DomainObjectCollectionFieldPopulator, ByNameDomainObjectFieldPopulator, DTODirectFieldPopulator, NoOperationDTOFieldPopulator]. 27
warning Missing a Javadoc comment. 29
warning Method 'populateDTO' is not designed for extension - needs to be abstract, final or empty. 31
warning Missing a Javadoc comment. 31
warning Parameter domainObject should be final. 31
warning Parameter dto should be final. 31
warning Line is longer than 120 characters. 38
warning Method 'populateDomainObject' is not designed for extension - needs to be abstract, final or empty. 61
warning Missing a Javadoc comment. 61
warning Parameter dto should be final. 61
warning Parameter domainObject should be final. 61
warning Missing a Javadoc comment. 79
warning Parameter field should be final. 79
warning Line is longer than 120 characters. 88
warning Missing a Javadoc comment. 95
warning Parameter dtoField should be final. 95

net/sf/hattori/repository/AbstractPersistentObjectDTO.java

Violation Message Line
warning Missing a Javadoc comment. 9
warning Missing a Javadoc comment. 11
warning Missing a Javadoc comment. 13
warning Method 'getId' is not designed for extension - needs to be abstract, final or empty. 15
warning Missing a Javadoc comment. 15
warning Method 'setId' is not designed for extension - needs to be abstract, final or empty. 19
warning Missing a Javadoc comment. 19
warning Parameter persistedObjectId should be final. 19
warning Method 'getVersion' is not designed for extension - needs to be abstract, final or empty. 23
warning Missing a Javadoc comment. 23
warning Method 'setVersion' is not designed for extension - needs to be abstract, final or empty. 27
warning Missing a Javadoc comment. 27
warning Parameter version should be final. 27
warning Method 'isTransient' is not designed for extension - needs to be abstract, final or empty. 31
warning Missing a Javadoc comment. 31
warning Method 'resetPersistentState' is not designed for extension - needs to be abstract, final or empty. 40
warning Method 'equals' is not designed for extension - needs to be abstract, final or empty. 45
warning Missing a Javadoc comment. 45
warning Parameter o should be final. 45
warning Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 50
warning Missing a Javadoc comment. 50
warning Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. 54
warning Missing a Javadoc comment. 54
warning Parameter o should be final. 54
warning Method 'toString' is not designed for extension - needs to be abstract, final or empty. 60
warning Missing a Javadoc comment. 60

net/sf/hattori/repository/EntityLocator.java

Violation Message Line
warning Missing a Javadoc comment. 3
warning Missing a Javadoc comment. 4
warning Redundant 'public' modifier. 4
warning Missing a Javadoc comment. 6
warning Redundant 'public' modifier. 6

net/sf/hattori/populators/domain/DomainObjectCollectionFieldPopulator.java

Violation Message Line
warning Missing a Javadoc comment. 20
warning Method 'populateField' is not designed for extension - needs to be abstract, final or empty. 22
warning Missing a Javadoc comment. 22
warning Parameter dtoField should be final. 22
warning Parameter dto should be final. 22
warning Parameter domainObject should be final. 22
warning Line is longer than 120 characters. 32
warning Line is longer than 120 characters. 40
warning Cyclomatic Complexity is 24 (max allowed is 10). 54
warning Missing a Javadoc comment. 54
warning NCSS for this method is 63 (max allowed is 50). 54
warning NPath Complexity is 2,738 (max allowed is 200). 54
warning Parameter dtoField should be final. 54
warning Parameter dto should be final. 54
warning Parameter domainObject should be final. 54
warning Line is longer than 120 characters. 74
warning Line is longer than 120 characters. 80
warning Line is longer than 120 characters. 81
warning Line is longer than 120 characters. 85
warning 'if' construct must use '{}'s. 92
warning Line is longer than 120 characters. 94
warning 'if' construct must use '{}'s. 110
warning Line is longer than 120 characters. 147
warning Line is longer than 120 characters. 155

net/sf/hattori/populators/domain/DomainObjectDirectFieldPopulator.java

Violation Message Line
warning Missing a Javadoc comment. 14
warning Method 'populateField' is not designed for extension - needs to be abstract, final or empty. 16
warning Missing a Javadoc comment. 16
warning Parameter dtoField should be final. 16
warning Parameter dto should be final. 16
warning Parameter domainObject should be final. 16
warning Cyclomatic Complexity is 11 (max allowed is 10). 44
warning Missing a Javadoc comment. 44
warning Parameter dtoField should be final. 44
warning Parameter dto should be final. 44
warning Parameter domainObject should be final. 44
warning Line is longer than 120 characters. 87
warning Line is longer than 120 characters. 103

net/sf/hattori/annotations/util/AbstractPersistentObjectStaticPopulator.java

Violation Message Line
warning Line is longer than 120 characters. 7
warning Missing a Javadoc comment. 7
warning Method 'populatePersistentProperties' is not designed for extension - needs to be abstract, final or empty. 9
warning Missing a Javadoc comment. 9
warning Parameter domainObject should be final. 9
warning Parameter dto should be final. 9

net/sf/hattori/annotations/FieldPopulation.java

Violation Message Line
warning Unused Javadoc tag. 42

net/sf/hattori/repository/PersistentObject.java

Violation Message Line
warning Missing a Javadoc comment. 10
warning Redundant 'public' modifier. 10
warning Missing a Javadoc comment. 12
warning Redundant 'public' modifier. 12
warning Missing a Javadoc comment. 14
warning Redundant 'public' modifier. 14
warning Missing a Javadoc comment. 16
warning Redundant 'public' modifier. 16
warning Missing a Javadoc comment. 18
warning Redundant 'public' modifier. 18

net/sf/hattori/log/package.html

Violation Message Line
warning Missing package documentation file. 0

net/sf/hattori/annotations/package.html

Violation Message Line
warning Missing package documentation file. 0

net/sf/hattori/populators/dto/DTOCollectionFieldPopulator.java

Violation Message Line
warning Missing a Javadoc comment. 18
warning Method 'populateDTOField' is not designed for extension - needs to be abstract, final or empty. 20
warning Missing a Javadoc comment. 20
warning Parameter field should be final. 20
warning Parameter domainObject should be final. 20
warning Parameter dto should be final. 20
warning Missing a Javadoc comment. 31
warning Parameter f should be final. 31
warning Parameter dto should be final. 31
warning Parameter domainObject should be final. 31
warning Line is longer than 120 characters. 41

net/sf/hattori/populators/dto/ByNameDTOFieldPopulator.java

Violation Message Line
warning Method 'populateDTOField' is not designed for extension - needs to be abstract, final or empty. 21
warning Missing a Javadoc comment. 21
warning Parameter field should be final. 21
warning Parameter domainObject should be final. 21
warning Parameter dto should be final. 21
warning Missing a Javadoc comment. 32
warning Parameter field should be final. 32
warning Parameter dto should be final. 32
warning Parameter domainObject should be final. 32

net/sf/hattori/exceptions/ConcurrentDTOException.java

Violation Message Line
warning Missing a Javadoc comment. 3
warning Missing a Javadoc comment. 5
warning Missing a Javadoc comment. 10
warning Parameter arg0 should be final. 10
warning Parameter arg1 should be final. 10
warning Missing a Javadoc comment. 15
warning Parameter arg0 should be final. 15
warning Missing a Javadoc comment. 20
warning Parameter arg0 should be final. 20

net/sf/hattori/exceptions/AnnotationConfigurationException.java

Violation Message Line
warning Missing a Javadoc comment. 10
warning Missing a Javadoc comment. 14
warning Parameter arg0 should be final. 14
warning Parameter arg1 should be final. 14
warning Missing a Javadoc comment. 18
warning Parameter arg0 should be final. 18
warning Missing a Javadoc comment. 22
warning Parameter arg0 should be final. 22

net/sf/hattori/exceptions/DTOPopulationException.java

Violation Message Line
warning Missing a Javadoc comment. 10
warning Missing a Javadoc comment. 14
warning Parameter arg0 should be final. 14
warning Parameter arg1 should be final. 14
warning Missing a Javadoc comment. 18
warning Parameter arg0 should be final. 18
warning Missing a Javadoc comment. 22
warning Parameter arg0 should be final. 22

net/sf/hattori/populators/PopulationState.java

Violation Message Line
warning Missing a Javadoc comment. 3
warning Missing a Javadoc comment. 4
warning Missing a Javadoc comment. 4

net/sf/hattori/populators/dto/DTODirectFieldPopulator.java

Violation Message Line
warning Unused import - org.apache.commons.lang.StringUtils. 5
warning Unused import - net.sf.hattori.populators.DynamicPopulator. 11
warning Missing a Javadoc comment. 16
warning Method 'populateDTOField' is not designed for extension - needs to be abstract, final or empty. 18
warning Missing a Javadoc comment. 18
warning Parameter field should be final. 18
warning Parameter domainObject should be final. 18
warning Parameter dto should be final. 18
warning Line is longer than 120 characters. 23
warning Line is longer than 120 characters. 28
warning Missing a Javadoc comment. 42
warning Parameter field should be final. 42
warning Parameter dto should be final. 42
warning Parameter domainObject should be final. 42

net/sf/hattori/annotations/util/UndefinedStaticPopulator.java

Violation Message Line
warning Method 'populateDTO' is not designed for extension - needs to be abstract, final or empty. 14
warning Missing a Javadoc comment. 14
warning Parameter domainObject should be final. 14
warning Parameter dto should be final. 14
warning Method 'populateDomainObject' is not designed for extension - needs to be abstract, final or empty. 18
warning Missing a Javadoc comment. 18
warning Parameter dto should be final. 18
warning Parameter domainObject should be final. 18

net/sf/hattori/populators/domain/package.html

Violation Message Line
warning Missing package documentation file. 0

net/sf/hattori/populators/dto/NoOperationDTOFieldPopulator.java

Violation Message Line
warning Method 'populateDTOField' is not designed for extension - needs to be abstract, final or empty. 18
warning Missing a Javadoc comment. 18
warning Parameter field should be final. 18
warning Parameter domainObject should be final. 18
warning Parameter dto should be final. 18